Request for review (L): 6797305: Add LoadUB and LoadUI opcode class

Christian Thalinger Christian.Thalinger at Sun.COM
Tue Mar 10 10:46:17 PDT 2009


On Tue, 2009-03-10 at 10:26 -0700, John Rose wrote:
> On Mar 10, 2009, at 5:08 AM, Christian Thalinger wrote:
> 
> > For the load shortening changes I'm currently doing it would be useful
> > to have these.  Can I add them under a new CR?
> 
> There is something like that already in assembler_sparc.hpp:
>       inline void lduw( const Address& a, Register d, int offset = 0 );
> 
> I thought you were talking about making Address easier to use...?

Right, and I didn't know if that is the same as on x86, is it?  I was a
bit confused because of the relocate() call.

And do these functions handle reg-reg loads properly too?

> If you just want to add a +4 offset, you can use the optional offset  
> argument above.

Sounds good.

> If you want to fold the offset into the Address itself, use  
> Address::plus_disp (which is new).

Sounds good too.  I will have a try.

-- Christian




More information about the hotspot-compiler-dev mailing list