Request for review (L): 6797305: Add LoadUB and LoadUI opcode class
Christian Thalinger
Christian.Thalinger at Sun.COM
Wed Mar 11 11:01:59 PDT 2009
On Wed, 2009-03-11 at 10:53 -0700, Tom Rodriguez wrote:
> >> Not sure how to rationalize all this into correspondence, except by
> >> improving bit by bit as improvements occur to us.
> >
> > Maybe I missing something here, but would it be possible to have a:
> >
> > Address Address::make_raw(int base, int index, int scale, int disp,
> > bool disp_is_oop) {
> >
> > function on SPARC too, so it's possible to use $mem$$Address in the AD
> > file and let (Address src, Register dst)-signature functions decide
> > which emit function to call? Furthermore we could assert on reg-reg
> > forms that have a displacement set, which is obviously wrong.
>
> That what I was assuming we'd do.
Should I go for it and post a webrev when I have something?
> I had no idea that sparc.ad even had support for VerifyOops. I'm not
> sure that logic that has to be preserved. It could be broken out
> separately as something that could be called from the ins_encode but
> I'm not really married to it.
Hmm, it's in the repository since duke at 0. Anyone else who knows
something about that?
-- Christian
More information about the hotspot-compiler-dev
mailing list