Request for review (L): 6797305: Add LoadUB and LoadUI opcode class

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Wed Mar 11 10:53:20 PDT 2009


>> Not sure how to rationalize all this into correspondence, except by
>> improving bit by bit as improvements occur to us.
>
> Maybe I missing something here, but would it be possible to have a:
>
>  Address Address::make_raw(int base, int index, int scale, int disp,  
> bool disp_is_oop) {
>
> function on SPARC too, so it's possible to use $mem$$Address in the AD
> file and let (Address src, Register dst)-signature functions decide
> which emit function to call?  Furthermore we could assert on reg-reg
> forms that have a displacement set, which is obviously wrong.

That what I was assuming we'd do.

> The only problem I see when using MacroAssembler instructions in
> sparc.ad is the VerifyOops check in emit_form3_mem_reg.  Is that still
> used/necessary or can it be moved somewhere else?

I had no idea that sparc.ad even had support for VerifyOops.  I'm not  
sure that logic that has to be preserved.  It could be broken out  
separately as something that could be called from the ins_encode but  
I'm not really married to it.

tom

>
>
> -- Christian
>




More information about the hotspot-compiler-dev mailing list