review (S) for 6822204: volatile fences should prefer lock:addl to actual mfence instruction

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Wed Mar 25 18:01:40 PDT 2009


Looks good.

To be consistent use "MEMBAR-volatile ! (empty encoding)"
instead of

!     } else {
!       $$emit$$"# empty membar_volatile"
!     }

Typo in the comment orderAccess_windows_x86.inline.hpp:
!   // Inline assmebly isn't supported so use a stub if it exists.  It
                  ^

Vladimir

Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/6822204
> 



More information about the hotspot-compiler-dev mailing list