review (S) for 6822204: volatile fences should prefer lock:addl to actual mfence instruction
Tom Rodriguez
Thomas.Rodriguez at Sun.COM
Thu Mar 26 11:07:44 PDT 2009
Fixed. Thanks!
tom
On Mar 25, 2009, at 6:01 PM, Vladimir Kozlov wrote:
> Looks good.
>
> To be consistent use "MEMBAR-volatile ! (empty encoding)"
> instead of
>
> ! } else {
> ! $$emit$$"# empty membar_volatile"
> ! }
>
> Typo in the comment orderAccess_windows_x86.inline.hpp:
> ! // Inline assmebly isn't supported so use a stub if it exists. It
> ^
>
> Vladimir
>
> Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/6822204
More information about the hotspot-compiler-dev
mailing list