Request for reviews (L): 6893081: method handle & invokedynamic code needs additional cleanup (post 6815692, 6858164)

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Mon Nov 30 16:01:53 PST 2009


Christian Thalinger wrote:
> On Tue, 2009-10-20 at 22:10 +0200, Christian Thalinger wrote:
>> This patch is one of the first ones:
>>
>> http://cr.openjdk.java.net/~twisti/6893081/webrev.01/
> 
> I fixed a small bug.  Here is the updated webrev:
> 
> http://cr.openjdk.java.net/~twisti/6893081/webrev.02/
> 
> -- Christian
> 

src/cpu/x86/vm/methodHandles_x86.cpp

Need comment update, 16+8+8+8 == 40
  678       // original 32-bit vmdata word must be of this form:
  679       //    | MBZ:16 | signBitCount:8 | srcDstTypes:8 | conversionOp:8 |

Use short jmpb() :
688       __ jmp(done);


src/cpu/x86/vm/sharedRuntime_x86_64.cpp

+       // we be generated.
            ^ will

src/cpu/x86/vm/templateInterpreter_x86_<32|64>.cpp
Do you have a bug for this problem to not forget about it?

Vladimir



More information about the hotspot-compiler-dev mailing list