Request for reviews (XL): 6829187: compiler optimizations required for JSR 292

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Mon Nov 30 17:16:47 PST 2009


Christian Thalinger wrote:
> This is the JSR 292 C2 compiler support:
> 
> http://cr.openjdk.java.net/~twisti/6829187/webrev.01/
> 
> -- Christian
> 

src/cpu/x86/vm/frame_x86.inline.hpp
Did you miss the next check or it was intentional?
  && last_sp >= sp()


src/cpu/x86/vm/x86_{32|64}.ad
Instead of using "/MethodHandle" in format %{%}
I would fix MachCallStaticJavaNode::dump_spec().

Why you can't add effect KILL ebp to CallStaticJavaHandle()?
If you do it do you still need idealreg2mhdebugmask[] masks?

src/share/vm/ci/ciCPCache.hpp.html
   27 // The class represents and entry in the constant pool cache.
                              ^ an ???
Should the class be called ciCPCacheEntry?

Vladimir


More information about the hotspot-compiler-dev mailing list