Request for reviews (XS): 6879902: CTW failure jdk6_18/hotspot/src/cpu/sparc/vm/assembler_sparc.hpp:845

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Mon Sep 21 12:25:18 PDT 2009


I actually told him not to since using arg_slot in i2c adapters seemed  
dubious to me since it adds in Interpreter::value_offset_in_bytes().   
I guess since the rest of the i2c code uses it we should use it but  
I'd like an assert that value_offset_in_bytes() == 0 in arg_slot.  I  
don't really like that i2c always forces constants into Rdisp instead  
of using the simm13 variants.  I think all of these should be using  
RegisterOrConstant and ensure_rs2 to deal with this issue.

tom

On Sep 21, 2009, at 10:54 AM, Vladimir Kozlov wrote:

> Christian,
>
> Why you did not use arg_slot(st_off)?
>
> Vladimir
>
> Christian Thalinger wrote:
>> http://cr.openjdk.java.net/~twisti/6879902/webrev.01/



More information about the hotspot-compiler-dev mailing list