Request for reviews (XS): 6879902: CTW failure jdk6_18/hotspot/src/cpu/sparc/vm/assembler_sparc.hpp:845

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Mon Sep 21 12:36:47 PDT 2009


OK. That explains it.
Changes looks good.

Vladimir

Christian Thalinger wrote:
> Vladimir Kozlov wrote:
>> Christian,
>>
>> Why you did not use arg_slot(st_off)?
> 
> I also talked with Tom about this issue and the problem with arg_slot()
> is that it's for interpreter frames.  Looking at arg_slot() it uses
> arg_offset() to calculate the offset:
> 
>   // base+st_off points to top of argument
>   int arg_offset(const int st_off) { return st_off +
> Interpreter::value_offset_in_bytes(); }
> 
> And this seems wrong when storing the arguments for the compiled frame.
> 
> -- Christian


More information about the hotspot-compiler-dev mailing list