Request for reviews (M): 6941529: SharedRuntime::raw_exception_handler_for_return_address must reset thread MethodHandle flag

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Apr 7 11:00:40 PDT 2010


Yes. Looks good.

Thanks,
Vladimir

Christian Thalinger wrote:
> On Wed, 2010-04-07 at 10:25 -0700, Vladimir Kozlov wrote:
>>>> !   void set_is_method_handle_return(int value)    { _is_method_handle_return = value; }
>>> Maybe I should change the argument type and do something like:
>>>
>>> void set_is_method_handle_return(bool value)    { _is_method_handle_return = value ? 1 : 0; }
>> Yes, it would be nice. Smart C++ compilers should fold it so the code
>> should be the same as before.
> 
> This should be better:
> 
> http://cr.openjdk.java.net/~twisti/6941529/webrev.02/
> 
> -- Christian
> 


More information about the hotspot-compiler-dev mailing list