Request for reviews (M): 6941529: SharedRuntime::raw_exception_handler_for_return_address must reset thread MethodHandle flag

[Tom Rodriguez]

This looks good.  Thanks for the rename.

tom

On Apr 7, 2010, at 10:18 AM, Christian Thalinger wrote:

> On Wed, 2010-04-07 at 09:49 -0700, Vladimir Kozlov wrote:
>> Christian,
>> 
>> Why you use int type to save boolean value?
> 
> The problem is that not all C compilers use the same data type size for
> a boolean.  So I use an int here.
> 
>> 
>> Next was confusing:
>> 
>> +   // Reset MethodHandle flag.
>> +   thread->set_is_method_handle_return(false);
>> 
>> since:
>> 
>> !   void set_is_method_handle_return(int value)    { _is_method_handle_return = value; }
> 
> Maybe I should change the argument type and do something like:
> 
> void set_is_method_handle_return(bool value)    { _is_method_handle_return = value ? 1 : 0; }
> 
> -- Christian
>