review (S) for 6976372: # assert(_owner == Thread::current()) failed: invariant

[Christian Thalinger]

On Wed, 2010-08-11 at 12:00 -0700, Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/6976372/
> 
> 6976372: #  assert(_owner == Thread::current()) failed: invariant
> Reviewed-by:
> 
> The full code cache path in the native wrapper has an unnecessary call
> to MutexUnlocker which asserts when executed.  The fix is simply to
> remove the call.  Additionally handle_full_code_cache assumes it's
> called from the CompilerThread but this isn't true for native
> wrappers.  The fix is to log to xtty if it exists, which also covers
> the LogCompilation case when called from a compiler thread.  Tested by
> faking code cache full in the debugger.
> 
> src/share/vm/runtime/sharedRuntime.cpp
> src/share/vm/compiler/compileBroker.cpp

Looks good.  -- Christian