Review Request: Zero and Shark fixes

[Gary Benson]

Christian Thalinger wrote:
> On Thu, 2010-08-12 at 11:52 +0100, Gary Benson wrote:
> > Hi all,
> > 
> > This webrev contains a number of fixes for Zero and Shark:
> > 
> >   http://cr.openjdk.java.net/~gbenson/zero-shark-fixes-01/
> 
> 6977640: Zero and Shark fixes
> 
> > Firstly, the two bugs 6953477 and 6730276 required changes
> > to be made to Zero. Secondly, an assertion that is invalid
> > on Shark was removed, which allows debug builds of Shark to
> > be built on ia32.
> 
> Hmm.  Two questions:
> 
> 1. Why does the assert not hold?

It's checking something about the stack layout which is true
with the native x86 stack but false with the Zero stack.

> 2. Why would anyone build Shark on x86?

Testing.  If you can reproduce an ARM issue on x86 then you
can build it in 30 seconds instead of 30 hours :)

Cheers,
Gary

-- 
http://gbenson.net/