Request for reviews .02 (XL): 6978355: renaming for 6961697

Tom Rodriguez tom.rodriguez at oracle.com
Tue Aug 24 09:07:50 PDT 2010


Looks good.

tom

On Aug 24, 2010, at 9:06 AM, Christian Thalinger wrote:

> On Mon, 2010-08-23 at 10:42 -0700, Tom Rodriguez wrote:
>> In the jniFastGetField can you switch:
>> 
>> +   address fast_entry = blob->code_begin();
>> 
>> to:
>> 
>> +   address fast_entry = __ pc();
>> 
>> Just so it matches how we normally do it.
> 
> OK.
> 
>> 
>> Don't forget to fix CodeBlob.java.
> 
> Ohh, I forgot that.
> 
>> 
>> Otherwise it looks ok.
> 
> Here is the updated webrev:
> 
> http://cr.openjdk.java.net/~twisti/6978355/webrev.02/
> 
> -- Christian
> 



More information about the hotspot-compiler-dev mailing list