Request for reviews (XS): 6974682: CTW: assert(target != NULL) failed: must not be null

[Christian Thalinger]

On Wed, 2010-08-04 at 17:03 -0700, Tom Rodriguez wrote:
> Your change seems ok but that const_size code is crap.  It always greatly overestimates the space needed.
> 
> #ifdef SPARC
>     // Sparc doubles entries in the constant table require more space for
>     // alignment. (expires 9/98)
>     int table_entries = (3 * instr->num_consts( _globalNames, Form::idealD ))
>       + instr->num_consts( _globalNames, Form::idealF );
> #else
>     int table_entries = instr->num_consts( _globalNames, Form::idealD )
>       + instr->num_consts( _globalNames, Form::idealF );
> #endif
> 
> So on sparc a double reserves 6 words.  It can/should be cleaned up as part of the changes Christian is working on.

Working on that.  -- Christian