Request for reviews (S): 6981431: IdealKit should support I_O projections

[Tom Rodriguez]

Sounds good.

tom

On Aug 31, 2010, at 8:14 PM, Vladimir Kozlov wrote:

> Thank you, Tom
> 
> I agree with passing GraphKit into IdealKit constructor. Also if I keep GraphKit pointer in IdealKit I can use
> ~IdealKit destructor for final sync instead of having separate method GraphKit::sync_kit(). But it is for an other round.
> 
> Thanks,
> Vladimir
> 
> On 8/31/10 7:48 PM, Tom Rodriguez wrote:
>> Looks good.  Maybe the IdealKit should take a GraphKit directly instead of each constructor call unpacking the arguments?  Instead of:
>> 
>>  IdealKit kit(gvn(), control(), merged_memory(), i_o(), false, true);
>> 
>> this:
>> 
>>  IdealKit kit(this, false, true);
>> 
>> I'm ok with how it is though.
>> 
>> tom
>> 
>> On Aug 31, 2010, at 6:30 PM, Vladimir Kozlov wrote:
>> 
>>> http://cr.openjdk.java.net/~kvn/6981431/webrev
>>> 
>>> Fixed 6981431: IdealKit should support I_O projections
>>> 
>>> IdealKit should support I_O projections to be able
>>> generate allocations by IdealKit.
>>> 
>>> Please, verify the new code in IdealKit which merges i_o.
>>> 
>>> Thanks,
>>> Vladimir
>>