Request for reviews (XL): 6919934: JSR 292 needs to support x86 C1

[Tom Rodriguez]

Can you change these to just say, // Not required for sparc

+ void LIR_Assembler::preserve_SP() {
+   // XXX I'm not sure yet if these are required on SPARC.
+ }
+ 
+ 
+ void LIR_Assembler::restore_SP() {
+   // XXX I'm not sure yet if these are required on SPARC.
+ }
+ 
+ 

c1_Runtime1_x86.cpp:

Why does this only have a value for NOT_LP64?  Isn't rsi ok for 64 bit?


+   const Register exception_oop_callee_saved = NOT_LP64(rsi);

Otherwise this looks good.

tom

On Feb 15, 2010, at 10:38 AM, Christian Thalinger wrote:

> http://cr.openjdk.java.net/~twisti/6919934/webrev.01/
> 
> This implements JSR 292 support for C1 x86.  It also includes changes
> from Tom that change C1 exception unwinding to operate as C2 does it.
> This makes the JSR 292 implementation easier.
> 
> Testing: JPRT
> 
> -- Christian