Request for reviews (XL): 6919934: JSR 292 needs to support x86 C1

[Christian Thalinger]

On 02/16/10 06:43 PM, Tom Rodriguez wrote:
> Can you change these to just say, // Not required for sparc
> 
> + void LIR_Assembler::preserve_SP() {
> +   // XXX I'm not sure yet if these are required on SPARC.
> + }
> + 
> + 
> + void LIR_Assembler::restore_SP() {
> +   // XXX I'm not sure yet if these are required on SPARC.
> + }
> + 
> +

I can change it yes, but I'm really not sure yet if we need to preserve
the SP on SPARC.

> 
> c1_Runtime1_x86.cpp:
> 
> Why does this only have a value for NOT_LP64?  Isn't rsi ok for 64 bit?
> 
> 
> +   const Register exception_oop_callee_saved = NOT_LP64(rsi);

No, RSI is an argument register on 64 bit and I didn't know which one to
use instead.  I guess any callee saved might do it?

-- Christian