Request for review (M): 6914206: change way of permission checking for generated MethodHandle adapters
John Rose
John.Rose at Sun.COM
Thu Jan 7 08:15:14 PST 2010
Yes, that's what I hoped for. Looks good. -- John
On Jan 7, 2010, at 6:33 AM, Christian Thalinger wrote:
> On Tue, 2010-01-05 at 10:56 -0800, Vladimir Kozlov wrote:
>> Why you not did it?:
>>
>> // FIXME: Hide this match logic in methodOopDesc or MethodHandleCompiler.
>
> Fixed. I added one test in methodOopDesc and the klass test in
> MethodHandleCompiler because of dependencies.
>
>> Should you also check for EnableMethodHandles flag in new code?
>
> Should we? I don't think it's necessary.
>
>> The next code fix only rbt. What about _rtype == T_ARRAY?
>>
>> + if (rbt == T_ARRAY) rbt = T_OBJECT;
>
> Thanks, I added that.
>
> Here is the new webrev:
>
> http://cr.openjdk.java.net/~twisti/6914206/webrev.02/
>
> -- Christian
>
More information about the hotspot-compiler-dev
mailing list