Request for reviews (S): 6730276: JDI_REGRESSION tests fail with "Error: count must be non-zero" error on x86

Paul Hohensee paul.hohensee at oracle.com
Wed Jun 9 12:33:49 PDT 2010


And conjoint_words, which also checks for zero length.

On 6/9/10 3:30 PM, Paul Hohensee wrote:
> Actually, gc copying is done by pd_disjoint_words, which checks for a
> zero length already.
>
> Paul
>
> On 6/9/10 3:13 PM, John Coomes wrote:
>> Vladimir Kozlov (vladimir.kozlov at oracle.com) wrote:
>>> http://cr.openjdk.java.net/~kvn/6730276/webrev
>>>
>>> Fixed 6730276: JDI_REGRESSION tests fail with "Error: count must be 
>>> non-zero" error on x86
>>>
>>> Replace assert_non_zero with if (count == 0) return.
>> The code change is fine, as long as there's no performance hit in GC.
>> The heaviest user of these routines is GC, and we call only when
>> there's something to copy.
>>
>> -John
>>


More information about the hotspot-compiler-dev mailing list