Request for reviews (S): 6730276: JDI_REGRESSION tests fail with "Error: count must be non-zero" error on x86

[John Coomes]

Paul Hohensee (paul.hohensee at oracle.com) wrote:
> Actually, gc copying is done by pd_disjoint_words, which checks for a
> zero length already.

Vladimir is adding an extra check to that path, in
Copy::disjoint_words* :-(.

-John

> On 6/9/10 3:13 PM, John Coomes wrote:
> > Vladimir Kozlov (vladimir.kozlov at oracle.com) wrote:
> >    
> >> http://cr.openjdk.java.net/~kvn/6730276/webrev
> >>
> >> Fixed 6730276: JDI_REGRESSION tests fail with "Error: count must be non-zero" error on x86
> >>
> >> Replace assert_non_zero with if (count == 0) return.
> >>      
> > The code change is fine, as long as there's no performance hit in GC.
> > The heaviest user of these routines is GC, and we call only when
> > there's something to copy.
> >
> > -John
> >
> >