Request for reviews (XL): 6919934: JSR 292 needs to support x86 C1

[Tom Rodriguez]

Looks good.

tom

On Mar 9, 2010, at 3:33 AM, Christian Thalinger wrote:

> On Tue, 2010-02-16 at 12:05 -0800, Tom Rodriguez wrote:
>>> I can change it yes, but I'm really not sure yet if we need to preserve
>>> the SP on SPARC.
>> 
>> I don't think they are and I'd rather not have XXX comments lying
>> around.  If they are needed then I suspect you'll figure it out
>> because of a new bug report, not because the comment is there.
> 
> Since I've already started the SPARC C1 port I know that we need to
> implement these methods.  I removed the comment and put an
> Unimplemented() there instead.
> 
>>> No, RSI is an argument register on 64 bit and I didn't know which one to
>>> use instead.  I guess any callee saved might do it?
>> 
>> Yep.
> 
> I used R14.
> 
> Here is an updated webrev and I will push that one:
> 
> http://cr.openjdk.java.net/~twisti/6919934/webrev.02/
> 
> -- Christian
>