Request for reviews .02 (L): 6951083: oops and relocations should part of nmethod not CodeBlob

Vladimir Kozlov vladimir.kozlov at Oracle.com
Mon May 17 09:35:15 PDT 2010


Looks good.

Vladimir

Christian Thalinger wrote:
> On Wed, 2010-05-12 at 10:15 -0700, Vladimir Kozlov wrote:
>> src/share/vm/code/oopRecorder.hpp
>>
>> // => code->copy_oops(_handles)
>>        ^ nm->
> 
> Done.
> 
>> src/share/vm/code/nmethod.hpp
>> Add embedded oop table information into nmethod's comment:
>>
>>   104 // A nmethod contains:
>>   105 //  - header                 (the nmethod structure)
> 
> Done.
> 
>> src/share/vm/includeDB_core
>> Why it is codeBlob.hpp and not nmethod.cpp?:
>>
>> + codeBlob.hpp                            jniHandles.hpp
> 
> Oops.  This looks like a leftover.  Removed.
> 
> http://cr.openjdk.java.net/~twisti/6951083/webrev.02/
> 
> -- Christian
> 


More information about the hotspot-compiler-dev mailing list