Request for reviews .02 (L): 6951083: oops and relocations should part of nmethod not CodeBlob
Christian Thalinger
Christian.Thalinger at Sun.COM
Mon May 17 06:05:04 PDT 2010
On Wed, 2010-05-12 at 10:15 -0700, Vladimir Kozlov wrote:
> src/share/vm/code/oopRecorder.hpp
>
> // => code->copy_oops(_handles)
> ^ nm->
Done.
>
> src/share/vm/code/nmethod.hpp
> Add embedded oop table information into nmethod's comment:
>
> 104 // A nmethod contains:
> 105 // - header (the nmethod structure)
Done.
> src/share/vm/includeDB_core
> Why it is codeBlob.hpp and not nmethod.cpp?:
>
> + codeBlob.hpp jniHandles.hpp
Oops. This looks like a leftover. Removed.
http://cr.openjdk.java.net/~twisti/6951083/webrev.02/
-- Christian
More information about the hotspot-compiler-dev
mailing list