review for 7062856: Disassembler needs to be smarter about finding hsdis after 1.7 launcher changes

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Jul 5 15:01:33 PDT 2011


Looks good.

Vladimir

Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/7062856
> 29 lines changed: 27 ins; 0 del; 2 mod; 487 unchg
> 
> 7062856: Disassembler needs to be smarter about finding hsdis after 1.7 launcher changes
> Summary: do explicit lookup emulating old LD_LIBRARY_PATH search
> Reviewed-by:
> 
> Changes to launcher in the JDK7 removed the default setting of
> LD_LIBRARY_PATH which was being used to find the disassembler.  I
> added explicit logic to perform a lookup equivalent to the previous
> behaviour.  Tested with truss to confirm search paths and
> PrintNMethods.
> 
> I also fixed an annoyance where every separate invocation of the
> disassembler emitted the "Disassembling ..." message so that it would
> only print it again if it changed.
> 


More information about the hotspot-compiler-dev mailing list