review for 7062856: Disassembler needs to be smarter about finding hsdis after 1.7 launcher changes

[John Rose]

Good.  Thanks for fixing that.

Instead of the comment "First try libhsdis for compatibility" I suggest laying out the whole search path, something like the following.

// Search for several paths derived from libjvm, in this order:
// 1. <home>/jre/lib/<arch>/<vm>/libhsdis.so
// 2. <home>/jre/lib/<arch>/<vm>/hsdis.so
// 3. <home>/jre/lib/<arch>/hsdis.so
// 4. hsdis.so  (no path)

-- John

On Jul 5, 2011, at 3:01 PM, Vladimir Kozlov wrote:

> Looks good.
> 
> Vladimir
> 
> Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/7062856
>> 29 lines changed: 27 ins; 0 del; 2 mod; 487 unchg
>> 
>> 7062856: Disassembler needs to be smarter about finding hsdis after 1.7 launcher changes
>> Summary: do explicit lookup emulating old LD_LIBRARY_PATH search

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20110705/f89e7a71/attachment.html