review request (URGENT): 7054590: (JSR-292) MethodHandleProxies.asInterfaceInstance() accepts private/protected nested interfaces
Christian Thalinger
christian.thalinger at oracle.com
Wed Jun 15 05:07:00 PDT 2011
On Jun 15, 2011, at 4:35 AM, John Rose wrote:
> (This has been previously reviewed under the bug 7052202. Here is a separate review for the record.)
>
> http://cr.openjdk.java.net/~jrose/7054590/webrev.00
>
> 7054590: (JSR-292) MethodHandleProxies.asInterfaceInstance() accepts private/protected nested interfaces
> Summary: fix non-compliant logic in MethodHandleProxies, fix invalid private classes in MethodHandlesTest
> Reviewed-by: twisti, never
Looks good. -- Christian
>
> This has been tested by new unit tests which are not included in this push. The unit tests may be examined here:
> http://hg.openjdk.java.net/mlvm/mlvm/jdk/file/tip/meth-unittests.patch (near 'asInterfaceInstance')
>
> Negative tests include:
> - non-interfaces Object, String
> - non-public-interface 'PrivateRunnable'
> - Interfaces without a unique method: CharSequence, java.io.Serializable
> - interfaces with a wrong-arity method: Runnable
>
> Positive tests include:
> - typical interface Runnable
> - overloaded interface Appendable
> - unchecked exceptions passed unwrapped
> - checked declared exceptions passed unwrapped
> - checked undeclared exceptions passed wrapped
More information about the hotspot-compiler-dev
mailing list