Request for reviews (S): 7192965: assert(is_aligned_sets(size)) failed: mask is not aligned, adjacent sets

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Aug 22 15:52:25 PDT 2012


Thank you, Christian

Yes, I forgot to add "static". Fixed.

Thanks,
Vladimir

Christian Thalinger wrote:
> On Aug 22, 2012, at 3:20 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
>> http://cr.openjdk.java.net/~kvn/7192965/webrev
>>
>> 7192965: assert(is_aligned_sets(size)) failed: mask is not aligned, adjacent sets
>>
>> Bias coloring in RA does not work for vectors with size > 64 bits, it only works for pairs (64 bits).
>> Change pair check to vector check. I did small refactoring and added comment.
>>
>> Tested with failing test.
> 
> src/share/vm/opto/chaitin.cpp:
> 
> + bool is_legal_reg(LRG &lrg, OptoReg::Name reg, int chunk) {
> 
> Should it be a static method?
> 
> -- Chris
> 
>> Thanks,
>> Vladimir
> 


More information about the hotspot-compiler-dev mailing list