review request (S) JSR292: SIGSEGV in JNIHandleBlock::release_block(JNIHandleBlock*, Thread*)+0x3c

[Christian Thalinger]

On Feb 7, 2012, at 2:37 PM, Roland Westrelin wrote:

>> The fix looks good.
> 
> Thanks Chris.
> 
>> 2975     // return address and rbp are already in place
>> 2976     __ subptr(rsp, (framesize-4) << LogBytesPerInt); // prolog
>> 
>> Not related to your change, this is pretty useless because it always subtracts zero.
> 
> Are you suggesting I do something about it?
> It's pretty armless IMO (i.e. in an out of line stub used for exception propagation).

Not sure.  At first I was just confused about all the calculation that results in a nop.

-- Chris

> 
> Roland.