review request (S): 7126041: jdk7u4 b05 and b06 crash with RubyMine 3.2.4, works well with b04

[Igor Veresov]

I'm actually fine either way, it's not that important. To me a private method of a class is more local than a module-wide declaration. 

igor


On Monday, February 13, 2012 at 12:04 PM, Roland Westrelin wrote:

> > A comment on the is_safepoint function would be helpful. Otherwise it looks good.
> 
> 
> Thanks. I'll add a comment. 
> Do you agree with Igor that the function should be a method of Canonicalizer. I think it's fine as a local utility function.
> 
> Roland. 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20120213/3a238970/attachment.html