review for 7144318: GCLocker assert failure: assert(_needs_gc || SafepointSynchronize::is_at_safepoint(

[Christian Thalinger]

Looks good.  -- Chris

On Feb 14, 2012, at 6:49 AM, Tom Rodriguez wrote:

> http://cr.openjdk.java.net/~never/7144318
> 21 lines changed: 13 ins; 6 del; 2 mod; 427 unchg
> 
> 7144318: GCLocker assert failure: assert(_needs_gc || SafepointSynchronize::is_at_safepoint(
> Reviewed-by:
> 
> The _needs_gc flag only changes from false to true during a safepoint
> but it can change from true to false at other times.  The new asserts
> are too strict for the combined call is_active_and_needs_gc since
> _needs_gc is checked twice and may change in between.  I was unable to
> reproduce the original failure but the failure mode is pretty clear.
>