Request for reviews (S): 6658428: C2 doesn't inline java method if corresponding intrinsic failed to inline

[John Rose]

On Feb 24, 2012, at 1:48 AM, Nils Eliasson wrote:

> New webrev here: http://cr.openjdk.java.net/~neliasso/6658428.01/webrev.03/

This is a good cleanup of a long-standing weakness; thanks.

I have one minor suggestion to improve code clarity:

+    // intrinsic was expecting to optimize. Should always be possible to
+    // get a normal java call that may inline in that case
-+    cg = C->call_generator(call_method, vtable_index, call_is_virtual, jvms, try_inline, prof_factor(), false);
++    bool allow_intrinsics = false;
++    cg = C->call_generator(call_method, vtable_index, call_is_virtual, jvms, try_inline, prof_factor(), allow_intrinsics);

In general, boolean arguments can get lost in long argument lists and are easier to read if marked with their name.  Another way to do it is: (…, /*allow_intrinsics=*/ false).

— John
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20120224/66910d9b/attachment.html