Request for reviews (S): 7131302: connode.cpp:205 Error: ShouldNotReachHere()

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Jan 18 22:18:23 PST 2012


http://cr.openjdk.java.net/~kvn/7131302/webrev

7131302: connode.cpp:205 Error: ShouldNotReachHere()

Split_thru_phi optimization used LoadNode::Value() and incorrectly replaced 
LoadS(StoreC(65535)) with constant (65535) which does not fit into SHORT type. 
As result merged Phi type become top.

Add Value() methods to short and byte Load nodes to truncate constants which 
does not fit.

Verified with failed test.

Thanks,
Vladimir


More information about the hotspot-compiler-dev mailing list