review request (S): 7090976 Eclipse/CDT causes a JVM crash while indexing C++ code

Tom Rodriguez tom.rodriguez at oracle.com
Tue Jan 31 09:19:15 PST 2012


On Jan 31, 2012, at 2:03 AM, Roland Westrelin wrote:

>> Because of invokedynamic I think your test for the existence of a receiver is in adequate.  I know I suggested passing the receiver all the time before but it might be simpler to only pass the receiver for this specific case.  That makes the tests more straightforward I think.  Otherwise it looks good.
> 
> And the webrev I sent didn't have the assignment to receiver of the checkcast result…
> 
> Here is a new one:
> http://cr.openjdk.java.net/~roland/7090976/webrev.01/

Looks good.

tom

> 
> Roland.



More information about the hotspot-compiler-dev mailing list