RFR (S): 8022494: Make compilation IDs sequential

John Rose john.r.rose at oracle.com
Wed Aug 7 18:50:22 PDT 2013


On Aug 6, 2013, at 10:55 PM, Albert Noll <albert.noll at oracle.com> wrote:

> please review this small patch.

It looks like you moved the test (for NULL) of method->code() outside of AdapterHandlerLibrary_lock.

This means that there will be races where multiple threads race to request a native wrapper.  They will all generate the code, sequentially grabbing AdapterHandlerLibrary_lock.  I think this is unnecessary concurrency.  I suggest that you keep the lines marked "See if somebody beat us to it".

— John
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130807/4b98f7f2/attachment.html 


More information about the hotspot-compiler-dev mailing list