RFR (S): 8022494: Make compilation IDs sequential

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Aug 7 19:26:13 PDT 2013


I think the simplest solution would be to make 
CompileBroker::assign_compile_id() public (note, it is static method) 
and call it from create_native_wrapper().

Vladimir

On 8/7/13 6:50 PM, John Rose wrote:
> On Aug 6, 2013, at 10:55 PM, Albert Noll <albert.noll at oracle.com
> <mailto:albert.noll at oracle.com>> wrote:
>
>> please review this small patch.
>
> It looks like you moved the test (for NULL) of method->code() outside of
> AdapterHandlerLibrary_lock.
>
> This means that there will be races where multiple threads race to
> request a native wrapper.  They will all generate the code, sequentially
> grabbing AdapterHandlerLibrary_lock.  I think this is unnecessary
> concurrency.  I suggest that you keep the lines marked "See if somebody
> beat us to it".
>
> — John


More information about the hotspot-compiler-dev mailing list