RFR(M): 7197327: 40% regression on 8 b41 comp 8 b40 on specjvm2008.mpegaudio on oob

[Vladimir Kozlov]

Could you move is_node_unreachable() to Node class and rename it?:

Node::is_unreachable(PhaseIterGVN &igvn);

Add a comment in add_expensive_node() why we reset control edge to NULL 
when OptimizeExpensiveOps == false so next person who look on it will 
not be confused.

We usually put asserts at the beginning of methods (before any checks):
assert(OptimizeExpensiveOps, "optimization off?");

I would use the same "Bad graph detected in 
get_early_ctrl_for_expensive" message in assert for bad graph check. 
Otherwise it is good.

Thanks,
Vladimir

On 2/4/13 2:31 AM, Roland Westrelin wrote:
> Hi Vladimir,
>
> Here is a new webrev that includes your suggestions:
>
> http://cr.openjdk.java.net/~roland/7197327/webrev.02/
>
> I wasn't sure the best way to do this:
>
>> We need more info if graph is broken. Could you dump_bad_graph() here:
>> +  assert(is_dominator(ctl, earliest) || is_dominator(earliest, ctl), "broken graph?");
>
> Can you check if it's ok?
>
> Thanks,
> Roland.
>