Request for review (S): JDK-8002169: TEST_BUG: compiler/7009359/Test7009359.java sometimes times out
Krystal Mo
krystal.mo at oracle.com
Mon Feb 11 15:52:28 PST 2013
Hi all,
Could I have a review on this small change, please?
Webrev: http://cr.openjdk.java.net/~kmo/8002169/webrev.00/
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8002169
The test may run into timeout easier if it were ran on the client
compiler (whereas the test was only meant to test the server compiler).
To make it less prone to timeout, I did the following changes:
1. instead of excluding main() from compiling, specify stringmakerBUG()
as dontinline in the CompileCommand, so that stringmakerBUG() will still
be compiled into its own native code whereas main can run much faster.
2. decrease the number of test loop iterations from 1000000 to 100000
Testing with JPRT,
and tested this version of the test with JDK7b124 which didn't have the
fix for 7009359 and verified the bug can still reproduce.
$ javac Test7009359.java
$ ./jdk1.7.0/fastdebug/bin/java -version
java version "1.7.0-ea-fastdebug"
Java(TM) SE Runtime Environment (build 1.7.0-ea-fastdebug-b124)
Java HotSpot(TM) 64-Bit Server VM (build 20.0-b05-fastdebug, mixed mode)
$ ./jdk1.7.0/fastdebug/bin/java -Xbatch -XX:+IgnoreUnrecognizedVMOptions
-XX:+OptimizeStringConcat
-XX:CompileCommand=dontinline,Test7009359,stringmakerBUG Test7009359
VM option '+IgnoreUnrecognizedVMOptions'
VM option '+OptimizeStringConcat'
VM option 'CompileCommand=dontinline,Test7009359,stringmakerBUG'
CompilerOracle: dontinline Test7009359.stringmakerBUG
StringBuffer(null) does not throw NPE
$ java -version
java version "1.7.0_09"
Java(TM) SE Runtime Environment (build 1.7.0_09-b05)
Java HotSpot(TM) 64-Bit Server VM (build 23.5-b02, mixed mode)
$ java -Xbatch -XX:+IgnoreUnrecognizedVMOptions
-XX:+OptimizeStringConcat
-XX:CompileCommand=dontinline,Test7009359,stringmakerBUG Test7009359
CompilerOracle: dontinline Test7009359.stringmakerBUG
$
Thanks,
Kris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130211/af12c150/attachment.html
More information about the hotspot-compiler-dev
mailing list