Request for reviews (S) 8005821 : C2: -XX:+PrintIntrinsics is broken

David Chase david.r.chase at oracle.com
Thu Jan 10 07:58:29 PST 2013


Webrev: http://cr.openjdk.java.net/~drchase/8005821/webrev.00/

Bug appeared as part of incremental inlining; a print data structure was not initialized appropriately.

Old behavior: -XX:+PrintIntrinsics would crash.
New behavior: -XX:+PrintIntrinsics doesn't crash.

Changes (all one-liners)
(1) modify initialization flag to match new printing behavior (fixes crash)
(2) modify dump_inlining method to also match new printing behavior (related behavioral glitch)
(3) fixed indenting of line calling dump_inlining.

Non-change (because someone will ask):
Did NOT fix intending of 150-line block preceding (3).
Body of block is aligned with surrounding code, but { and } are undented.
These were (historically) added to run some destructors at the right place.

David


More information about the hotspot-compiler-dev mailing list