Request for reviews (S) 8005821 : C2: -XX:+PrintIntrinsics is broken

[Vladimir Kozlov]

On 1/10/13 7:58 AM, David Chase wrote:
>
> Webrev: http://cr.openjdk.java.net/~drchase/8005821/webrev.00/

Changes are good.

>
> Bug appeared as part of incremental inlining; a print data structure was not initialized appropriately.
>
> Old behavior: -XX:+PrintIntrinsics would crash.
> New behavior: -XX:+PrintIntrinsics doesn't crash.

I would reverse this statement or would say it more clear:

before fix: -XX:+PrintIntrinsics would crash.
after  fix: -XX:+PrintIntrinsics doesn't crash.

We also add what testing was done. As I understand you ran it in JPRT 
which is enough for this fix.

Thanks,
Vladimir

>
> Changes (all one-liners)
> (1) modify initialization flag to match new printing behavior (fixes crash)
> (2) modify dump_inlining method to also match new printing behavior (related behavioral glitch)
> (3) fixed indenting of line calling dump_inlining.
>
> Non-change (because someone will ask):
> Did NOT fix intending of 150-line block preceding (3).
> Body of block is aligned with surrounding code, but { and } are undented.
> These were (historically) added to run some destructors at the right place.
>
> David
>