RFR (XS): 8014246: remove assert to catch access to object headers in index_oop_from_field_offset_long

Albert Noll albert.noll at oracle.com
Wed Jun 5 00:36:10 PDT 2013


Hi,

thanks for reviewing this small patch.

jbs: https://jbs.oracle.com/bugs/browse/JDK-8014246
webrev: http://cr.openjdk.java.net/~anoll/8014246/webrev.00/ 
<http://cr.openjdk.java.net/%7Eanoll/8014246/webrev.00/>

Problem:
Graal uses Unsafe access to implement e.g. monitorenter and monitorexit 
in Java. The assert added withJDK-7012072 
<https://jbs.oracle.com/bugs/browse/JDK-7012072>makes this impossible in 
debug builds.

Furthermore it is inconsistent since the assert is only in unsafe.cpp. 
If we compile and intrinsify one of these Unsafe methods the check does 
not apply.

Solution: remove assert

The jprt run was successful.

Best,
Albert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130605/f0dca51c/attachment.html 


More information about the hotspot-compiler-dev mailing list