RFR (XS): 8014246: remove assert to catch access to object headers in index_oop_from_field_offset_long

Christian Thalinger christian.thalinger at oracle.com
Wed Jun 5 13:34:24 PDT 2013


Looks good.  Maybe one additional reviewer would be good since I filed the bug.  -- Chris

On Jun 5, 2013, at 12:36 AM, Albert Noll <albert.noll at oracle.com> wrote:

> Hi,
> 
> thanks for reviewing this small patch. 
> 
> jbs: https://jbs.oracle.com/bugs/browse/JDK-8014246
> webrev: http://cr.openjdk.java.net/~anoll/8014246/webrev.00/
> 
> Problem: 
> Graal uses Unsafe access to implement e.g. monitorenter and monitorexit in Java. The assert added with JDK-7012072 makes this impossible in debug builds.
>  
> Furthermore it is inconsistent since the assert is only in unsafe.cpp. If we compile and intrinsify one of these Unsafe methods the check does not apply. 
> 
> Solution: remove assert
> 
> The jprt run was successful.
> 
> Best,
> Albert

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130605/00e8ed8c/attachment.html 


More information about the hotspot-compiler-dev mailing list