RFR (XS): 8010222: 8007439 disabled inlining of cold accessor methods

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Mar 18 14:02:41 PDT 2013


Thank you, John

I am pro strict rule of style - always use {}. It would be much easier 
to verify by auto tool.
It is not the first time we hit such problem.

Vladimir

On 3/18/13 12:32 PM, John Rose wrote:
> On Mar 18, 2013, at 11:31 AM, Vladimir Kozlov
> <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>> wrote:
>
>> http://cr.openjdk.java.net/~kvn/8010222/webrev/
>>
>> Fixed typo which cause this.
>
> It's a good fix.  Too bad about the typo.  — John
>
> P.S. That sort of bug can crop up in an editor that doesn't do
> context-sensitive indenting.
> I wonder if we should use a really basic style sniffer that would detect
> such "deceptive indents" such as:
>
> . . .if (foo)
> . . . .print("hello!");
> . . . .return true;
> or
> . . .if (foo)  print("hello!");
> . . . .return true;
>
> Such things must exist somewhere.
>
> (And, before anybody asks, I don't propose we start compensating for
> dumb text editors by requiring stricter or more uniform rules of style.
>   That would be so '80s.)


More information about the hotspot-compiler-dev mailing list