RFR (XS): 8010222: 8007439 disabled inlining of cold accessor methods

[Christian Thalinger]

On Mar 18, 2013, at 12:32 PM, John Rose <john.r.rose at oracle.com> wrote:

> On Mar 18, 2013, at 11:31 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
>> http://cr.openjdk.java.net/~kvn/8010222/webrev/
>> 
>> Fixed typo which cause this.
> 
> It's a good fix.  Too bad about the typo.  — John
> 
> P.S. That sort of bug can crop up in an editor that doesn't do context-sensitive indenting.
> I wonder if we should use a really basic style sniffer that would detect such "deceptive indents" such as:
> 
> . . .if (foo)
> . . . .print("hello!");
> . . . .return true;
> or
> . . .if (foo)  print("hello!");
> . . . .return true;
> 
> Such things must exist somewhere.

The main problem is there are some people who write code like:

  if (foo)
    return false;

without curly braces.  You know who you are ;-)

-- Chris

> 
> (And, before anybody asks, I don't propose we start compensating for dumb text editors by requiring stricter or more uniform rules of style.  That would be so '80s.)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130318/bae3e3a1/attachment-0001.html