RFR(M): 8039407 : Regression test needed for JDK-8015396

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Apr 17 19:32:45 UTC 2014


Hi David,

Can you use next style for the comment?

/*
  *
  */

And it would be good to see corresponding hex values in the comment 
which you use later in the code.

The comment needs more explanation what it is all about and why you are 
listing particular Windows machines configurations.

This test will test only Intepreter and not compiled jited code. You 
need at lest 3 iterations for compiled code to be used even with -Xcomp. 
I would suggest to create separate methods and call them from main() in 
a loop.

About bug itself. Was you able to reproduce the failure? It is not clear 
from report.

Thanks,
Vladimir

On 4/17/14 11:30 AM, David Chase wrote:
> Any chance of getting some reviews on this?
>
> On 2014-04-11, at 7:56 AM, David Chase <david.r.chase at oracle.com> wrote:
>> Changed to use Double.isNaN, retested with and without injected failure.
>>
>> webrev: http://cr.openjdk.java.net/~drchase/8039407/webrev.01/
>
>
> Original RFR:
>> Bug 8015396 needs a regression test; I cannot reproduce it so there is no "fix" to check in,
>> hence the separate bug to cover adding the test.  The test was included with the bug report,
>> and has been adapted here to jtreg.
>>
>> webrev: http://cr.openjdk.java.net/~drchase/8039407/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8039407
>>
>> testing: I artificially stuffed a "NaN" into the result value and observed that the test would then
>> report a failure.


More information about the hotspot-compiler-dev mailing list