RFR(S): 8005079: fix LogCompilation for incremental inlining

Roland Westrelin roland.westrelin at oracle.com
Thu Mar 20 13:59:30 UTC 2014


Thanks for reviewing this Vladimir.

> Can you always call some Compile's methods for logging which will check log() != NULL? I think it is not nice to have such checks in all places where we do logging. For example in callGenerator.cpp. You already have some such methods.

Ok.

> Does SymbolTable::lookup() recognize this klass name format?
> I am asking because replay tool (ciReplay.cpp) use lookup() to find klasses.  It would be nice if we can use the same format in replay (ciMethod::dump_name_as_ascii()) but it depends on SymbolTable::lookup().

It doesn’t look like it but I don’t know for sure.

> In compile.cpp CompileLog* log is not used.

Ok.

Here is a new webrev:

http://cr.openjdk.java.net/~roland/8005079/webrev.01/

Roland.

> 
> Thanks,
> Vladimir
> 
> On 3/18/14 11:56 AM, Roland Westrelin wrote:
>> This fixes the LogCompilation tool when incremental inlining happens. It required some extra data in the log file. I also changed the way the class names are reported in the log output so it uses the same as PrintInlining. It’s especially useful for lambda form:
>> 
>> java.lang.invoke.LambdaForm$MH/1282811396
>> 
>> rather than
>> 
>> java/lang/invoke/LambdaForm$MH
>> 
>> (which makes it hard to know what LF this is)
>> 
>> http://cr.openjdk.java.net/~roland/8005079/webrev.00/
>> 
>> Roland.
>> 



More information about the hotspot-compiler-dev mailing list