[9] RFR(S): 8059468: Fix PrintCodeCache output changed by JDK-8059137

Tobias Hartmann tobias.hartmann at oracle.com
Tue Sep 30 13:02:11 UTC 2014


Hi Albert,

thanks for the review.

On 30.09.2014 14:44, Albert Noll wrote:
> Looks good to me (not a reviewer).
>
> Minor nit (which need not be fixed): Wouldn't the naming be more 
> consistent if we call the non-method heap non-nmethod heap?
> *-    add_heap(non_method_space, "Code  Heap 'non-methods'", init_non_method_size, CodeBlobType::NonMethod);*

Yes, I changed it as you suggested:

http://cr.openjdk.java.net/~thartmann/8059468/webrev.01

Best,
Tobias

>
> Best,
> Albert
>
> On 09/30/2014 02:34 PM, Tobias Hartmann wrote:
>> Hi,
>>
>> please review this small patch that changes the output of 
>> -XX:+PrintCodeCache accidentally changed by JDK-8059137 [1] from 
>> 'Code Cache' back to 'CodeCache' because some tests depend on the output.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8059468
>> Webrev: http://cr.openjdk.java.net/~thartmann/8059468/webrev.00/
>>
>> Thanks,
>> Tobias
>>
>> [1] http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/3af889385bcf
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140930/8e1d650f/attachment.html>


More information about the hotspot-compiler-dev mailing list