[9] RFR(S): 8068440: Test6857159.java times out

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Feb 2 22:53:35 UTC 2015


Good.

Thanks,
Vladimir

On 2/1/15 11:56 PM, Albert Noll wrote:
> Hi Vladimir,
>
> thanks for looking at this. You are right, your suggestion makes the
> test more robust.
>
> Here is the new webrev:
> http://cr.openjdk.java.net/~anoll/8068440/webrev.01/
>
> Best,
> Albert
>
> On 01/29/2015 06:21 PM, Vladimir Kozlov wrote:
>> I know that script did the same but the code does not check that
>> method is really compiled - it only checks that output does not have
>> "COMPILE SKIPPED". We need to check that the method was really
>> compiled - for example, it has line for method compilation in
>> PrintCompilation output.
>>
>> Thanks,
>> Vladimir
>>
>> On 1/29/15 1:47 AM, Albert Noll wrote:
>>> Hi,
>>>
>>> Could I get reviews for this small patch?
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8068440
>>>
>>> Problem
>>> The test times out on Windows. The test uses a script to check that a
>>> particular method can be compiled. I suspect that
>>> there is a problem (deadlock) when using the script on Windows.
>>> However, I cannot prove it.
>>>
>>> Solution:
>>> Remove the script and do the check if the method was compiled
>>> correctly in Java. If the time-out goes away, the bug is
>>> fixed. If the time-out persists, we need look for a different cause.
>>>
>>> Testing:
>>> Local testing. Make sure that the method is still compiled in the new
>>> (Java-only) version.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~anoll/8068440/webrev.00/
>>>
>>> Many thanks in advance,
>>> Albert
>>>
>


More information about the hotspot-compiler-dev mailing list