[9] RFR(S): 8068440: Test6857159.java times out

[Igor Ignatyev]

On 02/02/2015 10:55 AM, Albert Noll wrote:
> Hi Igor,
>
> thanks for you response.
> On 01/29/2015 06:38 PM, Igor Ignatyev wrote:
>> I meant to check that exit code of spawn java process is zero.
>>
> Can I find that somewhere in the log files?
you can check it by OutputAnalyzer::shouldHaveExitValue(0)
>> also I missed that you use ProcessTools.createJavaProcessBuilder
>> instead of ProcessTools.executeTestJvm to spawn tested jvm. so created
>> jvm ignores external vm flags.
>>
> Is this ok?
nope, you should use ProcessTools::executeTestJvm, otherwise we'll 
unnoticeably lose coverage.
>
> Best,
> Albert
>
>> Igor
>>
>> On 01/29/2015 02:28 PM, Albert Noll wrote:
>>> Hi Igor,
>>>
>>> Thanks for looking at this. What do you mean by 'finish gracefully'?
>>> The process was killed after the timeout was hit.
>>>
>>> Thanks,
>>> Albert
>>>
>>> On 01/29/2015 11:30 AM, Igor Ignatyev wrote:
>>>> Hi Albert,
>>>>
>>>> could you also check that process was finished gracefully?
>>>>
>>>> otherwise the fix looks good to me.
>>>>
>>>> Thanks
>>>> Igor
>>>>
>>>> On 01/29/2015 12:47 PM, Albert Noll wrote:
>>>>> Hi,
>>>>>
>>>>> Could I get reviews for this small patch?
>>>>>
>>>>> Bug:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8068440
>>>>>
>>>>> Problem
>>>>> The test times out on Windows. The test uses a script to check that a
>>>>> particular method can be compiled. I suspect that there is a problem
>>>>> (deadlock) when using the script on Windows. However, I cannot
>>>>> prove it.
>>>>>
>>>>> Solution:
>>>>> Remove the script and do the check if the method was compiled
>>>>> correctly
>>>>> in Java. If the time-out goes away, the bug is fixed. If the time-out
>>>>> persists, we need look for a different cause.
>>>>>
>>>>> Testing:
>>>>> Local testing. Make sure that the method is still compiled in the new
>>>>> (Java-only) version.
>>>>>
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~anoll/8068440/webrev.00/
>>>>>
>>>>> Many thanks in advance,
>>>>> Albert
>>>>>
>>>
>