[9] RFR(XS): 8138810: rework tests for CompilerToVM::allocateCompiledId

[Tatiana Pivovarova]

Hi Christian!

Thank you for review!
I updated patch accordingly your comments
new webrev: http://cr.openjdk.java.net/~tpivovarova/8138810/webrev.01/

Tatiana

On 11/10/2015 11:42 PM, Christian Thalinger wrote:
> +            Asserts.assertTrue(ids.add(wbCompileID), testCase
> +                    + " : vm compilation allocated existed id " + id);
> +            Asserts.assertTrue(ids.add(id), testCase
> +                    + " : allocateCompileId returned existed id " + id);
>
> I think these should say “existing id”.  Otherwise this looks good.
>
>> On Nov 10, 2015, at 8:26 AM, Tatiana Pivovarova 
>> <tatiana.pivovarova at oracle.com 
>> <mailto:tatiana.pivovarova at oracle.com>> wrote:
>>
>> Hy guys!
>>
>> Please review this small patch
>> I just added loop to check that the allocation allocate new id on 
>> each iteration and used length of bytecode to define incorrect bci.
>>
>> Test:
>>   jtreg
>>
>> webrev: http://cr.openjdk.java.net/~tpivovarova/8138810/webrev.00/
>> bugid: https://bugs.openjdk.java.net/browse/JDK-8138810
>>
>> Thanks,
>> Tatiana
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151111/758c9420/attachment-0001.html>